tfiala added a comment.
I think this went in, right?
http://reviews.llvm.org/D14162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
OK looks good then.
http://reviews.llvm.org/D14162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
zturner added inline comments.
Comment at: packages/Python/lldbsuite/support/seven.py:12
@@ +11,3 @@
+import subprocess
+return (0, subprocess.check_output(command, shell=True))
+except subprocess.CalledProcessError as e:
tfiala wro
tfiala added a comment.
Just one question on the python 3 return code for non-exceptional exit.
Comment at: packages/Python/lldbsuite/support/seven.py:12
@@ +11,3 @@
+import subprocess
+return (0, subprocess.check_output(command, shell=True))
+exc
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
The purpose of this file is to fill in the gaps where `six` is lacking support
for some operation that we need.
Initially this just provides a replacement for the `commands` module which is
