Re: [Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

2015-10-26 Thread Oleksiy Vyalov via lldb-commits
ovyalov added a comment. In http://reviews.llvm.org/D14085#275507, @zturner wrote: > I think most of the time they are used in a Connection class, but I don't > think it's necessarily guaranteed they will always be that way. > > I can think of at least one use case in the future where we will ne

Re: [Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

2015-10-26 Thread Greg Clayton via lldb-commits
clayborg added a comment. In http://reviews.llvm.org/D14085#275507, @zturner wrote: > I think most of the time they are used in a Connection class, but I don't > think it's necessarily guaranteed they will always be that way. > > I can think of at least one use case in the future where we will n

Re: [Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

2015-10-26 Thread Zachary Turner via lldb-commits
zturner added a comment. I think most of the time they are used in a Connection class, but I don't think it's necessarily guaranteed they will always be that way. I can think of at least one use case in the future where we will need to open a socket to a server we don't control and stream some

Re: [Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

2015-10-26 Thread Greg Clayton via lldb-commits
clayborg added a comment. The plug-in interface I was thinking of was the Connection class. This would allow different platforms to support different Connection subclasses for things like network, serial, USB, Firewire, shared memory, IPC and others. Not sure if socket is stand alone enough to

Re: [Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

2015-10-26 Thread Zachary Turner via lldb-commits
zturner added a comment. I still think implementation should be in Host as well. If the idea is to simplify the creation scheme, then you could create an enum: enum class SocketType { Tcp, Udp, UnixDomain }; and provide a static method on SocketBase like this: class So

Re: [Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

2015-10-26 Thread Oleksiy Vyalov via lldb-commits
ovyalov added a comment. In http://reviews.llvm.org/D14085#275442, @zturner wrote: > I'm not sure I agree with this change. The interface to programming with > socket is by definition a property of the Host operating system. It seems to > me like Host was already the correct place for this co

Re: [Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

2015-10-26 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner requested changes to this revision. zturner added a reviewer: zturner. zturner added a comment. This revision now requires changes to proceed. I'm not sure I agree with this change. The interface to programming with socket is by definition a property

[Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

2015-10-26 Thread Oleksiy Vyalov via lldb-commits
ovyalov created this revision. ovyalov added a reviewer: clayborg. ovyalov added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. Make Socket to support plugin interface - moved implementation classes into source/Plugins/Socket folder and migrated most of use