[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

clayborg added a comment. Sorry this fell off my radar. I was on medical leave for a surgery for 3 months. Back now Comment at: lldb/tools/lldb-vscode/Watchpoint.cpp:72 + m_verified = true; + m_error = ""; +} Comment at: lldb/tools/lldb-v

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

wallace added a comment. Greg hasn't been working for a while. You can go ahead and land this, and when he gets back he can share some feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 __

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. Ping @clayborg would you mind having another look? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

wallace accepted this revision. wallace added a comment. This seems reasonable to me and I'm accepting it to unblock this feature. When Greg gets back he should be able to provide some additional comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

jingham added a comment. In D140630#4276855 , @cimacmillan wrote: > Ping. Greg's been out since late March, and isn't expected back for a while still. I am entirely unfamiliar with the lldb-vscode part of lldb, so I don't feel comfortable reviewing t

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

clayborg added a comment. Sorry for delay, I have been on vacation for the last two weeks. I will be back next Monday and get to this soon. Feel free to ping again next week if I don't get to it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14063

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan marked 12 inline comments as done. cimacmillan added a comment. @clayborg Thanks for your feedback. I've refactored the Watchpoint class slightly so that it encapsulates the parsing of the setDataBreakpoints request and be used to get the Breakpoint info to attach to the response. Th

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan updated this revision to Diff 493936. cimacmillan added a comment. Refactored Watchpoint class and addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 Files: lldb/packages/Pyt

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan marked 6 inline comments as done. cimacmillan added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2188 + +static std::optional set_data_breakpoint(const llvm::json::Object *breakpoint) { + std::string breakpoint_id = GetString(breakpoint, "id")

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint_data/TestVSCode_setDataBreakpoints.py:73 +num_a = array_find(locals, lambda x: x['name'] ==

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan updated this revision to Diff 490077. cimacmillan edited the summary of this revision. cimacmillan added a comment. Add handling for const and register cases. Setting watchpoint on SBValue rather than the address. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

clayborg added a comment. In D140630#4056641 , @cimacmillan wrote: > @clayborg Thanks for your feedback. I'm part the way through implementing > your changes. Specifically about this point: > >> I seem to remember that it will disable this watchpoint as

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. @clayborg Thanks for your feedback. I'm part the way through implementing your changes. Specifically about this point: > I seem to remember that it will disable this watchpoint as soon as a local > variable goes out of scope, though I might not be remember things co

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint_data/TestVSCode_setDataBreakpoints.py:74-81 +num_a = array_find(locals, lambda x: x['name']

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. Ping! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan created this revision. Herald added a project: All. cimacmillan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140630 Files: lldb/packages/Python/lldbsuite/tes