This revision was automatically updated to reflect the committed changes.
Closed by commit rGf2f3b1a87ad2: [lldb] Do not deallocate memory after exec
(authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140249/new/
https://reviews.
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140249/new/
https://reviews.llvm.org/D140249
jasonmolenda accepted this revision.
jasonmolenda added a comment.
LGTM. Jim?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140249/new/
https://reviews.llvm.org/D140249
___
lldb-commits mailing list
lld
bulbazord updated this revision to Diff 488035.
bulbazord added a comment.
Address @jingham's comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140249/new/
https://reviews.llvm.org/D140249
Files:
lldb/include/lldb/Target/Memory.h
lldb/sou
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
It doesn't seem unreasonable that in the course of time we'll come across
another circumstance where it's not worth deallocating these memory regions
(for instance, we really don't
bulbazord updated this revision to Diff 483692.
bulbazord added a comment.
Add a comment explaining why we do not dealloc after exec
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140249/new/
https://reviews.llvm.org/D140249
Files:
lldb/include/l
bulbazord added inline comments.
Comment at: lldb/source/Target/Memory.cpp:337
std::lock_guard guard(m_mutex);
- if (m_process.IsAlive()) {
+ if (m_process.IsAlive() && !did_exec) {
PermissionsToBlockMap::iterator pos, end = m_memory_map.end();
jasonmol
jasonmolenda added inline comments.
Comment at: lldb/source/Target/Memory.cpp:337
std::lock_guard guard(m_mutex);
- if (m_process.IsAlive()) {
+ if (m_process.IsAlive() && !did_exec) {
PermissionsToBlockMap::iterator pos, end = m_memory_map.end();
Shoul
bulbazord created this revision.
bulbazord added reviewers: jasonmolenda, jingham, JDevlieghere.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
After an exec has occured, resources used to manage the state of a
Process are cleaned up. One su
