This revision was automatically updated to reflect the committed changes.
Closed by commit rG9c5b97570502: [lldb] Report clang module build remarks
(authored by kastiglione).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140056/new/
https://reviews.
mib accepted this revision.
mib added a comment.
Yep, LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140056/new/
https://reviews.llvm.org/D140056
___
lldb-commits mailing list
lldb-commits@lists.llv
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
I like the new test! LGTM if @mib is happy.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140056/new/
https://reviews.llvm.org/D140056
__
kastiglione updated this revision to Diff 483379.
kastiglione added a comment.
Optimized test by using a minimal clang module; Addressed review feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140056/new/
https://reviews.llvm.org/D140056
Fil
kastiglione added inline comments.
Comment at:
lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:198
+// End the previous event before starting a new event.
+m_current_progress_up.reset(nullptr);
+m_current_progress_up.reset(new Progress(
kastiglione added inline comments.
Comment at:
lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:82
Log *m_log;
+ std::unique_ptr m_current_progress_up;
+ std::vector m_module_build_stack;
aprantl wrote:
> kastiglione wrote:
> > mib wrot
aprantl added a comment.
Nice! I have a suggestion to speed up the test and make it a little more robust.
Comment at:
lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:82
Log *m_log;
+ std::unique_ptr m_current_progress_up;
+ std::vector m_module_build
kastiglione added inline comments.
Comment at:
lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:82
Log *m_log;
+ std::unique_ptr m_current_progress_up;
+ std::vector m_module_build_stack;
mib wrote:
> `Progress` makes use of RAII to com
mib added inline comments.
Comment at:
lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:82
Log *m_log;
+ std::unique_ptr m_current_progress_up;
+ std::vector m_module_build_stack;
`Progress` makes use of RAII to complete the progress re
