Re: [Lldb-commits] [PATCH] D13985: Enable the libc++ tests on linux

2015-10-23 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251102: Enable the libc++ tests on linux (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13985?vs=38129&id=38221#toc Repository: rL LLVM http://reviews.llvm.org/D13985 Files

Re: [Lldb-commits] [PATCH] D13985: Enable the libc++ tests on linux

2015-10-22 Thread Todd Fiala via lldb-commits
tfiala added a comment. (I don't think you need to wait for Enrico, btw.) http://reviews.llvm.org/D13985 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13985: Enable the libc++ tests on linux

2015-10-22 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. Good catch! http://reviews.llvm.org/D13985 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [PATCH] D13985: Enable the libc++ tests on linux

2015-10-22 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: granata.enrico, tfiala. labath added a subscriber: lldb-commits. The list of loaded modules which skip_if_library_missing is depending on is not available on linux until after we run the target. This causes the tests to be wrongfully skipped.