Re: [Lldb-commits] [PATCH] D13968: [LLDB] Attempt to fix MSVC builds after rL250966

2015-10-22 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251031: Attempt to fix MSVC builds after rL250966. (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D13968?vs=38070&id=38143#toc Repository: rL LLVM http://reviews.llvm.

Re: [Lldb-commits] [PATCH] D13968: [LLDB] Attempt to fix MSVC builds after rL250966

2015-10-22 Thread Zachary Turner via lldb-commits
I would have done this last night but I didn't have a machine handy. I'll test it out now and commit if it fixes. And yea, in the future please just commit fixes. On Thu, Oct 22, 2015 at 6:04 AM Siva Chandra wrote: > sivachandra added a subscriber: sivachandra. > sivachandra added a comment. >

Re: [Lldb-commits] [PATCH] D13968: [LLDB] Attempt to fix MSVC builds after rL250966

2015-10-22 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner added a comment. I would have done this last night but I didn't have a machine handy. I'll test it out now and commit if it fixes. And yea, in the future please just commit fixes. Repository: rL LLVM http://reviews.llvm.org/D13968

Re: [Lldb-commits] [PATCH] D13968: [LLDB] Attempt to fix MSVC builds after rL250966

2015-10-22 Thread Siva Chandra via lldb-commits
sivachandra added a subscriber: sivachandra. sivachandra added a comment. If this fixes the windows build, can you please commit it ASAP? Repository: rL LLVM http://reviews.llvm.org/D13968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13968: [LLDB] Attempt to fix MSVC builds after rL250966

2015-10-21 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. lgtm. In the future you don't need to ask for a review to unbreak a build. Repository: rL LLVM http://reviews.llvm.org/D13968 ___ lldb-comm

[Lldb-commits] [PATCH] D13968: [LLDB] Attempt to fix MSVC builds after rL250966

2015-10-21 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: brucem, labath, clayborg. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Looks like MSVC build failure didn't relate to my changes, since I didn't remove lldb/Ex