Re: [Lldb-commits] [PATCH] D13866: Remove more gcc warnings.

2015-10-19 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Please don't check this in. If dwarf_r0 changes from 0 to another value, then this code will fail. We will need to live with these warnings. http://reviews.llvm.org/D13866 __

Re: [Lldb-commits] [PATCH] D13866: Remove more gcc warnings.

2015-10-19 Thread Joerg Sonnenberger via lldb-commits
On Mon, Oct 19, 2015 at 12:59:25PM +, Hafiz Abid Qadeer via lldb-commits wrote: > I saw following gcc warnings in 3 places and they seem to make sense. > > "comparison of unsigned expression >= 0 is always true [-Wtype-limits]" > > To fix the warnings, I have removed the offending checks. OK

[Lldb-commits] [PATCH] D13866: Remove more gcc warnings.

2015-10-19 Thread Hafiz Abid Qadeer via lldb-commits
abidh created this revision. abidh added a reviewer: clayborg. abidh added a subscriber: lldb-commits. I saw following gcc warnings in 3 places and they seem to make sense. "comparison of unsigned expression >= 0 is always true [-Wtype-limits]" To fix the warnings, I have removed the offending c