[Lldb-commits] [PATCH] D138589: Add runToBinaryEntry option for lldb-vscode

2022-11-23 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan abandoned this revision. yinghuitan added a comment. Discussed offline. We can't rely on initialized event because it has to happen before all breakpoints are set. Will create a new design for htis. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D138589: Add runToBinaryEntry option for lldb-vscode

2022-11-23 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Ideally this feature would enable a one shot breakpoint and let the startup happen just like it was before this patch. We don't want the user to see this stop right? It seems like we should allow some commands to be run with this one shot breakpoint and have it auto c

[Lldb-commits] [PATCH] D138589: Add runToBinaryEntry option for lldb-vscode

2022-11-23 Thread Greg Clayton via Phabricator via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We have to let the IDE set breakpoints after the "initialized" packet is sent and _then_ do this functionality. So this patch needs to be modified to make that happen. ===

[Lldb-commits] [PATCH] D138589: Add runToBinaryEntry option for lldb-vscode

2022-11-23 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch add