This revision was automatically updated to reflect the committed changes.
Closed by commit rG7bf3cb3ee871: [lldb] Fix issue with re.Pattern availability
(authored by kastiglione).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137582/new/
https://rev
JDevlieghere accepted this revision.
JDevlieghere added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137582/new/
https://reviews.llvm.org/D137582
___
lldb-commits mailing list
lldb-commi
kastiglione updated this revision to Diff 473812.
kastiglione added a comment.
Switch to getting the type dynamically instead of by name.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137582/new/
https://reviews.llvm.org/D137582
Files:
lldb/pack
kastiglione updated this revision to Diff 473811.
kastiglione added a comment.
Use short circuit to avoid eager eval of `re.SRE_Pattern`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137582/new/
https://reviews.llvm.org/D137582
Files:
lldb/packa
kastiglione added a comment.
> Anyway to test this ?
I don't have a Python 3.6 to test with. I did test locally which caught an
issue, so I am at least confident it won't regress anything.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137582/new/
mib accepted this revision.
mib added a comment.
LGTM! Anyway to test this ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137582/new/
https://reviews.llvm.org/D137582
___
lldb-commits mailing list
lldb-
rastogishubham accepted this revision.
rastogishubham added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137582/new/
https://reviews.llvm.org/D137582
__
kastiglione updated this revision to Diff 473768.
kastiglione added a comment.
Simplify the fallback expression.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137582/new/
https://reviews.llvm.org/D137582
Files:
lldb/packages/Python/lldbsuite/tes
kastiglione created this revision.
kastiglione added reviewers: mib, rastogishubham, JDevlieghere.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
`re.Pattern` is introduced in Python 3.7. To support
