Re: [Lldb-commits] [PATCH] D13742: Fix codesign command with cmake.

2015-10-14 Thread Stephane Sezer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250335: Fix codesign command with cmake. (authored by sas). Changed prior to commit: http://reviews.llvm.org/D13742?vs=37387&id=37405#toc Repository: rL LLVM http://reviews.llvm.org/D13742 Files:

Re: [Lldb-commits] [PATCH] D13742: Fix codesign command with cmake.

2015-10-14 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D13742 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [PATCH] D13742: Fix codesign command with cmake.

2015-10-14 Thread Stephane Sezer via lldb-commits
sas created this revision. sas added reviewers: clayborg, dawn, brucem, tfiala. sas added a subscriber: lldb-commits. Looks like having a space in the Xcode path triggers this bug. We need to use cmake -E env FOO=bar [COMMAND] to set the environment instead. I am using cmake 3.3.1 and ninja 1.6.0