[Lldb-commits] [PATCH] D136958: [lldb] Document QSetDetachOnError packet

2022-11-01 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9c9afbb76f82: [lldb] Document QSetDetachOnError packet (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136958/new/ https://reviews.llv

[Lldb-commits] [PATCH] D136958: [lldb] Document QSetDetachOnError packet

2022-11-01 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
fdeazeve added a comment. In D136958#3896820 , @jasonmolenda wrote: > debugserver often can't tell the difference between these (when you run a > process on a local system, lldb actually does the posix_spawn and then tells > debugserver to attach to it

[Lldb-commits] [PATCH] D136958: [lldb] Document QSetDetachOnError packet

2022-10-31 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. LGTM. Not really the place for it, but the idea is: if lldb launched a process, when lldb quits, the inferior process should be killed. But if lldb attached to a running process, when lldb quits, the inferior process should be

[Lldb-commits] [PATCH] D136958: [lldb] Document QSetDetachOnError packet

2022-10-28 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM, thanks for adding this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136958/new/ https://reviews.llvm.org/D136958

[Lldb-commits] [PATCH] D136958: [lldb] Document QSetDetachOnError packet

2022-10-28 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The packet was introduced in 106d02866d4d54b09c08e6a12915dba58e709294. Repository: rG LLVM Github Monorepo https://re