This revision was automatically updated to reflect the committed changes.
Closed by commit rL250295: lldb-server: add support for binary memory reads
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D13695?vs=37341&id=37342#toc
Repository:
rL LLVM
http://reviews.llvm.o
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D13695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
labath updated this revision to Diff 37341.
labath added a comment.
Remove files which slipped in...
http://reviews.llvm.org/D13695
Files:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
source/Plu
labath updated this revision to Diff 37340.
labath added a comment.
The new functionality gets picked up by the client and automatically used
everywhere, so I'm not
really worried about testing it. A more important issue would be making sure
that the legacy read
packet does not rot as it is now
zturner added a subscriber: zturner.
zturner added a comment.
Any tests for this?
http://reviews.llvm.org/D13695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Any tests for this?
On Tue, Oct 13, 2015 at 7:49 AM Tamas Berghammer via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> tberghammer accepted this revision.
> tberghammer added a comment.
> This revision is now accepted and ready to land.
>
> Look good
>
>
> http://reviews.llvm.org/D13695
>
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Look good
http://reviews.llvm.org/D13695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
labath created this revision.
labath added reviewers: tberghammer, jasonmolenda.
labath added subscribers: lldb-commits, iancottrell.
This commit adds support for binary memory reads ($x) to lldb-server. It also
removes the "0x"
prefix from the $x client packet, to make it more compatible with th
