[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c8995649afa: Add formatting support for VSCode logpoints message (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https:

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan updated this revision to Diff 471676. yinghuitan added a comment. Add failure case testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https://reviews.llvm.org/D136697 Files: lldb/test/API/tools/lldb-vscode/breakpoint/T

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

clayborg added a comment. What happens when we have a log message error? I see we log to the console, but we should test this. Also, if there is an error, do we fail the breakpoint setting completely or do we just not set the log message? We need a test for these cases. Repository: rG LLVM

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan updated this revision to Diff 471318. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https://reviews.llvm.org/D136697 Files: lldb/test/API/tools/lldb-vscode/breakpoint/Tes

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a few nits and this is good to go Comment at: lldb/tools/lldb-vscode/BreakpointBase.cpp:56 +formatted += text.substr(0, backslash_pos).str(); +// S

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan updated this revision to Diff 471314. yinghuitan added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https://reviews.llvm.org/D136697 Files: lldb/test/API/tools/lldb-vscode/breakpoint/Te

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/BreakpointBase.cpp:306 } + output.push_back('\n'); // Ensure log message has line break. g_vsc.SendOutput(OutputType::Console, output.c_str()); clayborg wrote: > I would still only push o

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/BreakpointBase.cpp:29 +lldb::SBError BreakpointBase::AppendLogMessagePart(llvm::StringRef part, + bool is_expr) { + if (is_expr) { clayb

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/BreakpointBase.cpp:29 +lldb::SBError BreakpointBase::AppendLogMessagePart(llvm::StringRef part, +

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan updated this revision to Diff 470837. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https://reviews.llvm.org/D136697 Files: lldb/test/API/tools/lldb-vscode/breakpoint/Tes

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_logpoints.py:52 logMessage_prefix = "This is log message for { -- " -# Trailing newline is needed for splitlines() -logMessage = logMessage_prefix + "{i +

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_logpoints.py:52 logMessage_prefix = "This is log message for { -- " -# T

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://rev