[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

labath added a comment. Ah, now I see that patch didn't land yet. In the future, I think you can land simple changes like that without waiting for a (pre-commit) review, but if you don't feel comfortable doing that, then please revert the original patch so as to not leave the build in a broken

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

labath added a comment. Unfortunately, it looks like that patch broke things too. I haven't looked at the cause too closely, as the error was the same on linux and macos, but if you have problems reproducing it, let me know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan added a comment. The test failure is fixed in https://reviews.llvm.org/D138536 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 ___ lldb-commits maili

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf0c16f89124f: Add runToBinaryEntry option for lldb-vscode (authored by yinghuitan). Changed prior to commit: https://re

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan updated this revision to Diff 468593. yinghuitan added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscod

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan updated this revision to Diff 468592. yinghuitan added a comment. Update message per feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 Files: lldb/packages/Python/lldbsuite/test/tools/

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan updated this revision to Diff 468591. yinghuitan added a comment. Use async model. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Woops, forgot, you will need to modify the package.json to document the new launch config options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Fix the comment as suggested and good to go. Also please test on both macOS and linux to ensure this works on both prior to pushing the diff, I often have issues on either side with lldb-v

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch