This revision was automatically updated to reflect the committed changes.
Closed by commit rGf4991bfa891e: [lldb] Improve display of absolute symbol
lookup (authored by alvinhochun, committed by mstorsjo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
clayborg accepted this revision.
clayborg added a comment.
Thanks for fixing the issue!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134516/new/
https://reviews.llvm.org/D134516
___
lldb-commits mailing
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:1552
strm.IndentMore();
+ strm.Indent("Name: ");
+ strm.PutCStrin
alvinhochun added inline comments.
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:1552
strm.IndentMore();
+ strm.Indent("Name: ");
+ strm.PutCString(symbol->GetDisplayName().GetStringRef());
DavidSpickett wrote:
> Could
DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added inline comments.
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:1552
strm.IndentMore();
+ strm.Indent("Name: ");
+ strm.PutCString(symbol->GetDisplayName().GetStringRef()
alvinhochun created this revision.
alvinhochun added reviewers: labath, clayborg.
Herald added a project: All.
alvinhochun requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
When running `target module lookup` command, show the name of absolut