treapster added a comment.
It seems like the new code doesn't check zstd version, thus breaking the build
if you have something below 1.4.0.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133530/new/
https://reviews.llvm.org/D133530
__
MaskRay added a comment.
Ping for unresolved issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133530/new/
https://reviews.llvm.org/D133530
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
labath added a comment.
Seems fine to me, though you may want to have a llvm test for the new
functionality, given that the patch is exclusively changing llvm code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133530/new/
https://reviews.llvm.org
MaskRay added inline comments.
Comment at: lldb/test/Shell/ObjectFile/ELF/compressed-sections-zstd.yaml:19
+Content: deadbeefbaadf00d
+## The legacy .zdebug format is not supported.
+ - Name:.zdebug_info
Delete `.zdebug`. It is unrelated
