[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

2022-09-06 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added a comment. thanks for the fast reply Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133365/new/ https://reviews.llvm.org/D133365 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

2022-09-06 Thread Dave Lee via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG940704cc585e: [lldb] Fix CommunicationKDP following D133251 (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133365/new/ https://rev

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

2022-09-06 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. … and thanks a lot for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133365/new/ https://reviews.llvm.org/D133365 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

2022-09-06 Thread Michał Górny via Phabricator via lldb-commits
mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. That's the same thing that I did for gdb-remote, so I suppose it is correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133365/new/ https://r

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

2022-09-06 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added a comment. Note that these two fields are only used in `CommunicationKDP::CheckForPacket`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133365/new/ https://reviews.llvm.org/D133365 ___

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

2022-09-06 Thread Dave Lee via Phabricator via lldb-commits
kastiglione created this revision. kastiglione added reviewers: mgorny, labath, aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add `m_bytes` and `m_bytes_mutex` to `CommunicationKDP`, follo