[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2670b92a254: Fix a bug in lldb-dotest that was uncovered by setting no value for… (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13307

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks, that makes more sense! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133075/new/ https://reviews.llvm.org/D133075 ___

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

jingham added a comment. Actually, I confused myself because I still had the other fix in place. G... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133075/new/ https://reviews.llvm.org/D133075 ___

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

jingham updated this revision to Diff 457138. jingham added a comment. This one actually works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133075/new/ https://reviews.llvm.org/D133075 Files: lldb/utils/lldb-dotest/lldb-dotest.in Index: lldb

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

jingham added a comment. In D133075#3762872 , @jingham wrote: > In D133075#3762869 , @aprantl wrote: > >> Interesting, I would have expected `array.extend([])` be a noop? > > Me too. Too bad the Python folks don'

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

jingham added a comment. In D133075#3762869 , @aprantl wrote: > Interesting, I would have expected `array.extend([])` be a noop? Me too. Too bad the Python folks don't check with us more often... Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

jingham added a comment. Or really, we split the string, resulting in an empty array, and apparently `cmd.extend([])` adds an empty argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133075/new/ https://reviews.llvm.org/D133075 _

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

aprantl added a comment. Interesting, I would have expected `array.extend([])` be a noop? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133075/new/ https://reviews.llvm.org/D133075 ___ lldb-commits maili

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

jingham created this revision. jingham added reviewers: JDevlieghere, kastiglione, aprantl, labath. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When - after substitution - the dotest_args_str is empt