[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc9e6c52f3d8: Add auto deduce source map setting (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan updated this revision to Diff 460973. yinghuitan added a comment. Fix nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/ https://reviews.llvm.org/D133042 Files: lldb/include/lldb/Breakpoint/BreakpointResolverFileLine.h ll

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

clayborg added a comment. Just one nit about double checking if auto deducing is enabled. Fix that and this is good to go. Comment at: lldb/source/Breakpoint/BreakpointResolverFileLine.cpp:305 + if (GetBreakpoint()->GetTarget().GetAutoSourceMapRelative()) +DeduceSourceM

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan updated this revision to Diff 460578. yinghuitan added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/ https://reviews.llvm.org/D133042 Files: lldb/include/lldb/Breakpoint/BreakpointResolve

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

clayborg added inline comments. Comment at: lldb/source/Breakpoint/BreakpointResolverFileLine.cpp:225 + const bool case_sensitive = request_file.IsCaseSensitive(); + const bool full = !request_file.GetDirectory().IsEmpty(); + for (uint32_t i = 0; i < sc_list.GetSize(); ++i) {

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan added a comment. @clayborg, now I see you want to make this option true by default while full paths one to be optional. Then sure, it makes sense. Comment at: lldb/source/Breakpoint/BreakpointResolverFileLine.cpp:225 + const bool case_sensitive = request_file.IsCas

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

clayborg added a comment. In D133042#3791146 , @yinghuitan wrote: > @clayborg , it is my intention to make `target.auto-deduce-source-map` > boolean flag ultimately working for both relative paths and two full paths > (two full paths are really importa

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan updated this revision to Diff 460270. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/ https://reviews.llvm.org/D133042 Files: lldb/include/lldb/Breakpoint/BreakpointResolve

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan added a comment. @clayborg , it is my intention to make `target.auto-deduce-source-map` boolean flag ultimately working for both relative paths and two full paths (two full paths are really important for off build host debugging, e.g. dump or production debugging). In this patch, I f

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. The main question for me here is if "target.auto-deduce-source-map" should be a boolean or an enum. This path, if I read it correctly, will only auto deduce source maps if the de

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new