[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

baoyuxu added a comment. @kasper81, I just tried this patch with lastest repo in github and can bulid patched lldb. But when I try to remote debug with riscv qemu, it still get all 1s frame. Could you please see what I'm doing wrong？ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 added a comment. @labath, if there is anything needed by me, please let me know. i'm new to phabricator patch system. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510 _

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 requested review of this revision. kasper81 added a comment. @MaskRay could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510 ___

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. In D132510#3771030 , @kasper81 wrote: > @jasonmolenda, @Emmmer, any other feedback, or good to merge? i will work on > `Plugins/Architectu

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 added a comment. @jasonmolenda, @Emmmer, any other feedback, or good to merge? i will work on `Plugins/Architecture/RISCV`, unless someone else beat me to it. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.ll

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 added a comment. @Emmmer, agreed that automated tests for ABI plugins would be a nice thing to have at some point in the future, but it is out of the scope of this initial bring up for RISCV, as tests are missing for all architectures. Also we need `Plugins/Architecture`port for RISCV

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 marked 2 inline comments as done. kasper81 added a comment. Addressed review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510 ___ lldb-commits

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 updated this revision to Diff 455982. kasper81 marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510 Files: lldb/source/Plugins/ABI/CMakeLists.txt lldb/source/Plugin

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 updated this revision to Diff 455977. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510 Files: lldb/source/Plugins/ABI/CMakeLists.txt lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp lldb/source

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

Emmmer added a subscriber: labath. Emmmer added a comment. I have to say sorry after reading your update but not giving you feedback. I pulled your patch and found it does not compile, and I have fixed them for you :) In D62732#2306055 , @labath wrote: >

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 added a comment. @jasonmolenda. @Emmmer, I've addressed your review feedback. Could you please take another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 updated this revision to Diff 455371. kasper81 added a comment. Added a `FIXME` comment in `CreateDefaultUnwindPlan`, based on advice from @jasonmolenda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

jasonmolenda added a comment. In D132510#3745412 , @kasper81 wrote: > @jasonmolenda the problem with original review is that we were waiting for > the wholesale support for 3.5 years, and it rendered into an impossible task > for the author. I don't wan

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:38 + +enum riscv_dwarf_regnums { + dwarf_x0 = 0, Emmmer wrote: > This enum can be included from `lldb/source/Utility/RISCV_DWARF_Registers.h` Thanks, I have reused that h

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 updated this revision to Diff 455177. kasper81 marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510 Files: lldb/source/Plugins/ABI/CMakeLists.txt lldb/source/Plugin

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 updated this revision to Diff 455176. kasper81 added a comment. Reuse existing dwarf enum. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510 Files: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 added a comment. @jasonmolenda the problem with original review is that we were waiting for the wholesale support for 3.5 years, and it rendered into an impossible task for the author. I don't want to make this one "all or none" kind of a deal as well. This patch is n neither bringing

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

Emmmer added a comment. Currently, `lldb/source/Plugins/Instruction/RISCV/EmulateInstructionRISCV.cpp` only handles a few jump instructions, we can refine it further if needed. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:38 + +enum riscv_dwarf_regnums { + dwar

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

jasonmolenda added a comment. I think this DefaultUnwindPlan has the same problem that the previous patch did -- this looks like the unwind state on function entry. There is an `ABI::CreateFunctionEntryUnwindPlan()` for the unwind state on the first instruction of a function, but the idea of D

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 created this revision. kasper81 added reviewers: DavidSpickett, Emmmer, tzb99. kasper81 added a project: LLDB. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, JDevlieghere, s.egerton, Jim, benna, psnobl, jocewei, P