This revision was automatically updated to reflect the committed changes.
Closed by commit rL248903: Add support for .ARM.exidx unwind information
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13245?vs=35970&id=36101#toc
Repository:
rL LLVM
http://reviews.llvm
tberghammer marked an inline comment as done.
Comment at: source/Symbol/ArmUnwindInfo.cpp:62
@@ +61,3 @@
+static uint64_t
+GetULEB128(const uint32_t* data, uint16_t& offset, uint16_t max_offset)
+{
labath wrote:
> Is there a reason DataExtractor::GetULEB128 could
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D13245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
jasonmolenda added a comment.
Looks good to me, I don't have anything beyond Pavel's suggestions. I don't
know the format of the ARM .exidx .extab unwind info so I don't have any
feedback on the parsing of that.
I forgot about that code in RegisterContextLLDB::GetFullUnwindPlanForFrame()
for
labath added a subscriber: labath.
labath added a comment.
I don't know much about the arm unwind info, but I have some style comments
from a casual read-through.
Comment at: include/lldb/Symbol/UnwindTable.h:71
@@ -67,4 +70,3 @@
-DWARFCallFrameInfo* m_eh_frame;
-Comp
tberghammer created this revision.
tberghammer added a reviewer: jasonmolenda.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
.ARM.exidx/.ARM.extab sections contain unwind information used on ARM
architecture from unwinding from an exception.
http://r
