Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-10-05 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249377: [LLDB][MIPS] Fix hit_count for mips watchpoints (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13241?vs=35958&id=36583#toc Repository: rL LLVM http://reviews.

Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-10-05 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Back from vacation, sorry for the delay. Looks good. Repository: rL LLVM http://reviews.llvm.org/D13241 ___ lldb-commits mailing list lldb

Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-09-30 Thread Zachary Turner via lldb-commits
Ahh, so the test was already failing and you're just fixing it? That's fine then, thanks. On Tue, Sep 29, 2015 at 11:24 PM Jason Molenda wrote: > jasonmolenda added a comment. > > I see, this seems reasonable to me. > > > Repository: > rL LLVM > > http://reviews.llvm.org/D13241 > > > > __

Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-09-30 Thread Zachary Turner via lldb-commits
zturner added a comment. Ahh, so the test was already failing and you're just fixing it? That's fine then, thanks. Repository: rL LLVM http://reviews.llvm.org/D13241 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org

Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-09-29 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. I see, this seems reasonable to me. Repository: rL LLVM http://reviews.llvm.org/D13241 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-09-29 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added a comment. Jason, in MIPS watch registers, last 3 bits of watchpoint addresses are masked by IRW(instruction, read, write types) flags, so machine gives exception for any address having other bits same to the actual watch address execept last 3 bits. Comment at line number 7

Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-09-29 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner added a comment. Can you add a test for this? Repository: rL LLVM http://reviews.llvm.org/D13241 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-09-29 Thread Zachary Turner via lldb-commits
Can you add a test for this? On Tue, Sep 29, 2015 at 5:41 PM Jason Molenda via lldb-commits < lldb-commits@lists.llvm.org> wrote: > jasonmolenda added a subscriber: jasonmolenda. > jasonmolenda added a comment. > > Greg's out this week, he or Jim may want to comment. > > I was curious about this

Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-09-29 Thread Jason Molenda via lldb-commits
jasonmolenda added a subscriber: jasonmolenda. jasonmolenda added a comment. Greg's out this week, he or Jim may want to comment. I was curious about this method IncrementFalseAlarmsAndReviseHitCount, there weren't any calls to it. A little digging shows that the one use of it was removed in r

[Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-09-29 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added a reviewer: clayborg. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Revise hit counts when hit a false positive Repository: rL LLVM ht