[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe17cae076c47: [trace][intel pt] Fix per-psb packet decoding (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

wallace updated this revision to Diff 452313. wallace marked an inline comment as done. wallace added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131630/new/ https://reviews.llvm.org/D131630 Files: lldb/include/lldb/Target/Tr

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:440 +Expected> lldb_private::trace_intel_pt::SplitTraceInContinuousExecutions( +TraceIntelPT &trac

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

wallace marked 4 inline comments as done. wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:476-478 + if (event.has_tsc) { +tsc = event.tsc; +break; jj10306 wrote: > so is this inner loop what's a

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

jj10306 requested changes to this revision. jj10306 added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:164-166 + /// \param[in] decoder + /// A decoder configured to start and end within the

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

wallace updated this revision to Diff 451685. wallace added a comment. improve documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131630/new/ https://reviews.llvm.org/D131630 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

wallace updated this revision to Diff 451670. wallace edited the summary of this revision. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131630/new/ https://reviews.llvm.org/D131630 Files: lldb/include/lldb/Target/Tr

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The per-PSB packet decoding logic was wrong because it was assuming that pt_