This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfe01292457fc: Move FormattersMatchCandidate flags to a
struct. (authored by jgorbe).
Changed prior to commit:
https://reviews.llvm.org/D131459?vs=
labath accepted this revision.
labath added inline comments.
Comment at: lldb/include/lldb/DataFormatters/FormatClasses.h:50
+ struct Flags {
+bool m_stripped_pointer = false;
+bool m_stripped_reference = false;
We don't generally use the `m_` prefix on
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
LGTM, a nice improvement.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131459/new/
https://reviews.llvm.org/D131459
jgorbe created this revision.
Herald added a project: All.
jgorbe requested review of this revision.
Herald added a project: LLDB.
Move FormattersMatchCandidate flags to a struct.
This removes some error-prone repetition in
FormatManager::GetPossibleMatches, where the same three boolean flags
are
