[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

fixathon added a comment. Commented on feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131294/new/ https://reviews.llvm.org/D131294 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

fixathon added a comment. In D131294#3707154 , @jingham wrote: > We don't use the constant first so you don't accidentally use "=" rather than > "==" convention anywhere else in lldb, so it looks weird here. Good feedback. I'll switch that around. Rep

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

jingham added a comment. We don't use the constant first so you don't accidentally use "=" rather than "==" convention anywhere else in lldb, so it looks weird here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131294/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa4977f2e135: [LLDB][NFC] Reliability fixes to TCPSocket code (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131294/new/ https://revi

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131294/new/ https://reviews.llvm.org/D131294 __

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

hawkinsw added a comment. Not that my opinion means much, but the changes look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131294/new/ https://reviews.llvm.org/D131294 ___ lldb-commits mail

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Patch the following issues found by static code inspectio