[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

2022-08-03 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added inline comments. Herald added a subscriber: Michael137. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:269-272 +elif enum == lldb.eStopReasonInstrumentation: +return "instrumentation" +elif enum == lldb.eStopReasonProcessorTrace: +

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

2022-08-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG0f821339dad1: [lldb] Add assertStopReason helper function (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

2022-08-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:269-272 +elif enum == lldb.eStopReasonInstrumentation: +return "instrumentation" +elif enum == lldb.eStopReasonProcessorT

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

2022-08-03 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:269-272 +elif enum == lldb.eStopReasonInstrumentation: +return "instrumentation" +elif enum == lld

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

2022-08-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 449707. JDevlieghere added a comment. Add missing stop reasons CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131083/new/ https://reviews.llvm.org/D131083 Files: lldb/docs/resources/test.rst lldb/packages/Python/lldbsuite/test/lldbtest.py

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

2022-08-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: mib, kastiglione, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Add a function to make it easier to debug a test failure caused by an unexpected stop reason. This is similar to the `assertSta