[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9b4ea0ce9ef: [trace] Add SBTraceCursor bindings (authored by jj10306). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130930/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. yaay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130930/new/ https://reviews.llvm.org/D130930 _

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

jj10306 updated this revision to Diff 449462. jj10306 added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130930/new/ https://reviews.llvm.org/D130930 Files: lldb/bindings/interface/SBTrace.i lldb/bindings/interface/SBTraceCurso

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

jj10306 updated this revision to Diff 449461. jj10306 marked 4 inline comments as done. jj10306 added a comment. Revert changes to DecodedThread trace item getter API's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130930/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

wallace added inline comments. Comment at: lldb/bindings/interface/SBTraceCursor.i:56 + + explicit operator bool() const; +}; +1 Comment at: lldb/include/lldb/API/SBTraceCursor.h:21 +public: + /// Default constructor for an invalid \a SBTrace

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

jj10306 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:201 lldb::TraceEvent DecodedThread::GetEventByIndex(int item_index) const { + // This currently returns an undefined value when the item isn't an event. return m_item_data[item_in

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

jj10306 updated this revision to Diff 449289. jj10306 marked 4 inline comments as done. jj10306 added a comment. 1. address comments 2. rebase 3. minor changes to `DecodedThread::GetInstructionLoadAddress` and `DecodedThread::GetErrorByIndex` Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

jj10306 marked 13 inline comments as done. jj10306 added inline comments. Comment at: lldb/include/lldb/API/SBTraceCursor.h:166 + /// The specific kind of event the cursor is pointing at, or \b + /// TraceEvent::eTraceEventNone if the cursor not pointing to an event. +

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. pretty nice!! Just some few minor changes and good to go Comment at: lldb/bindings/interface/SBTraceCursor.i:1-7 +//===-- SWIG Interface for SBTraceCursor.h -

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBTraceCursor.h:1-2 +//===-- SBTraceCursor.h ---*- C++ +//-*-===// +// Broken ASCII art Comment at: lldb/source/API/SBTrace.cpp:47

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

jj10306 created this revision. jj10306 added reviewers: wallace, persona0220. Herald added a subscriber: mgorny. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add bindings for the `TraceCursor` to allo