Re: [Lldb-commits] [PATCH] D13056: Fix race condition during process detach

2015-09-28 Thread Pavel Labath via lldb-commits
labath added a comment. I have reverted this for now. This fix is not complete without http://reviews.llvm.org/D12968. Repository: rL LLVM http://reviews.llvm.org/D13056 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D13056: Fix race condition during process detach

2015-09-25 Thread Oleksiy Vyalov via lldb-commits
ovyalov added a subscriber: ovyalov. ovyalov added a comment. It looks like this CL is introducing additional latency when destroying process - I noticed 10 seconds delay when destroying Android process and got logs for code with this CL and without: 1443231085.125153000 Process::StopForDestroy

Re: [Lldb-commits] [PATCH] D13056: Fix race condition during process detach

2015-09-23 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248371: Fix race condition during process detach (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13056?vs=35372&id=35476#toc Repository: rL LLVM http://reviews.llvm.org/D1305

Re: [Lldb-commits] [PATCH] D13056: Fix race condition during process detach

2015-09-22 Thread Kirill Lapshin via lldb-commits
KLapshin added a comment. See http://reviews.llvm.org/D12968 also - fix for missed hijacked listener set in Process::HaltForDestroyOrDetach() http://reviews.llvm.org/D13056 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D13056: Fix race condition during process detach

2015-09-22 Thread Pavel Labath via lldb-commits
labath updated this revision to Diff 35372. labath added a comment. remove some binaries that managed to sneak in http://reviews.llvm.org/D13056 Files: include/lldb/Target/Process.h source/Target/Process.cpp test/functionalities/attach_resume/TestAttachResume.py Index: test/functionaliti

[Lldb-commits] [PATCH] D13056: Fix race condition during process detach

2015-09-22 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: jingham, clayborg. labath added a subscriber: lldb-commits. The following situation occured in TestAttachResume: The inferior was stoped at a breakpoint and we did a continue, immediately followed by a detach. Since there was a trap instructi