[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

aprantl added a comment. In D130062#3789858 , @kpdev42 wrote: > In D130062#3789671 , @aprantl wrote: > >> Out of curiosity — did you get an email notification from the bot? > > Hi, yes, I will add a priority to th

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

kpdev42 added a comment. In D130062#3789671 , @aprantl wrote: > Out of curiosity — did you get an email notification from the bot? Hi, yes, I will add a priority to these notifications to react faster, sorry Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

aprantl added a comment. Out of curiosity — did you get an email notification from the bot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130062/new/ https://reviews.llvm.org/D130062 ___ lldb-commits mai

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

aprantl added a comment. This test fails to compile on Darwin https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46816/testReport/junit/lldb-api/commands_expression_macros/TestMacros_py/ https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46811/ Can you please add a @skipIfDarwin de

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0fb69d17b4d: [lldb][DWARF5] Enable macro evaluation (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130062/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

kpdev42 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130062/new/ https://reviews.llvm.org/D130062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

kpdev42 updated this revision to Diff 451364. kpdev42 added a comment. Address review notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130062/new/ https://reviews.llvm.org/D130062 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp:96 + return LoadOrGetSection(eSectionTypeDWARFDebugMacro, + eSectionTypeDWARFDebugMacro, m_data_debug_macro); } Never mind me! Just checke

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp:95-96 const DWARFDataExtractor &DWARFContext::getOrLoadMacroData() { - return LoadOrGetSection(eSectionTypeDWARFDebugMacro, llvm::None, - m_data_debug_macr

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

tschuett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.h:27 +struct DWARFStrOffsetsInfo { + lldb::offset_t cu_offset; If you would use a class instead of the struct, you could hide the member variables. The class var

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

kpdev42 created this revision. kpdev42 added reviewers: clayborg, davide, k8stone, DavidSpickett. kpdev42 added a project: LLDB. Herald added subscribers: Enna1, JDevlieghere, mgorny. Herald added a project: All. kpdev42 requested review of this revision. Herald added a reviewer: jdoerfert. Herald