krytarowski abandoned this revision.
krytarowski added a comment.
Closing. We are going for reuse of the NetBSD native curses(8) library.
The reason for it is limit of detecting ncurses on various systems. For
example, Ubuntu ships with `` and linkage from ``,
`ncurses.h` isn't detected by CMak
krytarowski added a comment.
There is already preliminary NetBSD support merged with trunk, I need this
commit (or altered version of it) to build lldb against ncurses on this
platform.
Thank you for your time.
Repository:
rL LLVM
http://reviews.llvm.org/D12994
_
krytarowski added inline comments.
Comment at: include/lldb/Config/config.h.cmake:6
@@ +5,3 @@
+#else
+#define CONFIG_H
+
krytarowski wrote:
> brucem wrote:
> > brucem wrote:
> > > This should be `LLDB_CONFIG_CONFIG_H` rather than just `CONFIG_H`.
> > >
> > > Als
krytarowski updated this revision to Diff 35922.
krytarowski added a comment.
Fix typo.
Repository:
rL LLVM
http://reviews.llvm.org/D12994
Files:
CMakeLists.txt
cmake/LLDBDependencies.cmake
cmake/modules/LLDBConfig.cmake
include/lldb/Config/config.h.cmake
include/lldb/Config/config
krytarowski added inline comments.
Comment at: include/lldb/Config/config.h.cmake:6
@@ +5,3 @@
+#else
+#define CONFIG_H
+
brucem wrote:
> brucem wrote:
> > This should be `LLDB_CONFIG_CONFIG_H` rather than just `CONFIG_H`.
> >
> > Also, why not use the same `#ifn
labath added a subscriber: labath.
labath added a comment.
In http://reviews.llvm.org/D12994#254468, @brucem wrote:
> I'm also not sure offhand how this would impact the Xcode build that the
> Apple folks use.
Since the xcode build is only used on Darwin, I think we can hardcode any
#defines
brucem added a subscriber: brucem.
brucem added a comment.
Some mostly superficial comments.
I'd like to hear if anyone else has an opinion about using a Config.h generated
by cmake & autotools.
I'm also not sure offhand how this would impact the Xcode build that the Apple
folks use.
And I di
krytarowski created this revision.
krytarowski added a reviewer: joerg.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
Summary of the changes:
- add config.h (CMake and autotools target).
- Handle ncurses with a proper CMake find_pack
