[Lldb-commits] [PATCH] D129736: [lldb] Skip a float16 NaN test for RISC-V

2022-07-14 Thread Emmmer S via Phabricator via lldb-commits
Emmmer abandoned this revision. Emmmer added a comment. Superseded by D129750 , which introduced a platform independent way of checking floating point test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12973

[Lldb-commits] [PATCH] D129736: [lldb] Skip a float16 NaN test for RISC-V

2022-07-14 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. That code is horrible. Lemme see if I can remove it (=> D129750 ). If that doesn't work, then we can try skipping this... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129736/new/ https://

[Lldb-commits] [PATCH] D129736: [lldb] Skip a float16 NaN test for RISC-V

2022-07-14 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. Seems fine to me. Do you have a tracking issue for this? You could just open one for "lldb riscv test failures" and add comments as you find more failures. So people can see the current state of the test suite. Comment at: lldb/unittests/Core/Du

[Lldb-commits] [PATCH] D129736: [lldb] Skip a float16 NaN test for RISC-V

2022-07-14 Thread Emmmer S via Phabricator via lldb-commits
Emmmer created this revision. Emmmer added reviewers: MaskRay, liaolucy, craig.topper, DavidSpickett. Emmmer added projects: LLDB, LLDB test suite on simulator. Herald added subscribers: jsji, sunshaoce, VincentWu, luke957, StephenFan, vkmr, luismarques, sameer.abuasal, JDevlieghere, pengfei, s.eg