Re: [Lldb-commits] [PATCH] D12964: [lldb-server] No need to add pthread twice.

2015-09-21 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. thanks Repository: rL LLVM http://reviews.llvm.org/D12964 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12964: [lldb-server] No need to add pthread twice.

2015-09-21 Thread Daniel Sanders via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248177: [lldb-server] No need to add pthread twice. (authored by dsanders). Changed prior to commit: http://reviews.llvm.org/D12964?vs=35086&id=35277#toc Repository: rL LLVM http://reviews.llvm.org/

Re: [Lldb-commits] [PATCH] D12964: [lldb-server] No need to add pthread twice.

2015-09-21 Thread Daniel Sanders via lldb-commits
dsanders added a comment. 'ninja clean' seems to have made the lldb-mi link failure go away. Presumably something didn't rebuild when the references to llvm_regcomp and llvm_regfree were added. I'll run the lldb tests and then commit this. http://reviews.llvm.org/D12964 ___

Re: [Lldb-commits] [PATCH] D12964: [lldb-server] No need to add pthread twice.

2015-09-21 Thread Daniel Sanders via lldb-commits
dsanders added a comment. Thanks. I've acquired a new link failure (this time on lldb-mi) since my last build so I'll commit this once I have a temporary fix in place for that and can run the tests again. http://reviews.llvm.org/D12964 ___ lldb-co

Re: [Lldb-commits] [PATCH] D12964: [lldb-server] No need to add pthread twice.

2015-09-18 Thread Daniel Sanders via lldb-commits
dsanders updated this revision to Diff 35086. dsanders added a comment. Correct the patch. Arcanist created the diff based on a revision prior to r247991 for some reason. http://reviews.llvm.org/D12964 Files: tools/lldb-server/CMakeLists.txt Index: tools/lldb-server/CMakeLists.txt =

[Lldb-commits] [PATCH] D12964: [lldb-server] No need to add pthread twice.

2015-09-18 Thread Daniel Sanders via lldb-commits
dsanders created this revision. dsanders added subscribers: krytarowski, labath, lldb-commits. Following on from r247991: pthread is in LLDB_SYSTEM_LIBS so there's no need to explicitly add it to the link. http://reviews.llvm.org/D12964 Files: tools/lldb-server/CMakeLists.txt Index: tools/ll