This revision was automatically updated to reflect the committed changes.
Closed by commit rGe83d47f6b7bd: When the module path for `command script
import` is invalid, echo the path. (authored by jingham).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129338/new/
https://reviews.llvm.org/D129338
___
jingham updated this revision to Diff 445145.
jingham added a comment.
I added the pathname to the "invalid directory" output, but when the test
passes an invalid directory we still execute the "invalid pathname" branch but
not the "invalid directory" branch. I don't know enough about the llvm
DavidSpickett added inline comments.
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:2640
if (!pathname || !pathname[0]) {
-error.SetErrorString("invalid pathname");
+error.SetErrorString("empty path");
return false;
-
hawkinsw added inline comments.
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:2717
if (module_file.GetDirectory().IsEmpty()) {
error.SetErrorString("invalid directory name");
return false;
Sorry for
jingham created this revision.
jingham added a reviewer: JDevlieghere.
Herald added a project: All.
jingham requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
When there's an error with the pathname in "command script import" lldb just
says "
