[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan added a comment. > From Jim, First off, I am supportive of your project, this is a pain point > for some folks for sure. I am in favor of trying to automate "I built my > binaries with sources in one location but locally they are in another" > scenario. Great to hear that! Seems all

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

labath added a comment. In D129307#3646623 , @clayborg wrote: >> - The fact that the breakpoint path `/src/foo/bar.cc` could match debug info >> path `/build/foo/bar.cc` is definitely strange. > > Not strange at all for production builds where you build

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

clayborg added a comment. In D129307#3644730 , @labath wrote: > I originally wanted to stay out of this, but then we got a path-resolving bug > report which got me thinking about all of this. > > Generally I would say I agree with Jim, that this is a imp

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

clayborg added a comment. In D129307#3644044 , @jingham wrote: > In D129307#3643426 , @yinghuitan > wrote: > >> @jingham, thanks for sharing the thoughts. > > First off, I am supportive of your project, this is a

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

labath added a comment. I originally wanted to stay out of this, but then we got a path-resolving bug report which got me thinking about all of this. Generally I would say I agree with Jim, that this is a important problem to solve, but the implementation is somewhat unusual. I don't really hav

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

jingham added a comment. In D129307#3643426 , @yinghuitan wrote: > @jingham, thanks for sharing the thoughts. First off, I am supportive of your project, this is a pain point for some folks for sure. I am in favor of trying to automate "I built my bin

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan added a comment. @jingham, thanks for sharing the thoughts. > Setting the breakpoint search to only check base names will of course make > all your file and line breakpoints work, but they will also pick up extra > hits. In command line lldb that doesn't look nearly as weird as click

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

jingham added a comment. I'm out tomorrow, so I won't get a chance for a detailed reply till Monday. But my short reactions are: 1. Setting the breakpoint search to only check base names will of course make all your file and line breakpoints work, but they will also pick up extra hits. In co

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

clayborg added a comment. In D129307#3637310 , @jingham wrote: > In D129307#3636695 , @clayborg > wrote: > >> In D129307#3636573 , @jingham >> wrote: >> >>> I'm not enti

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

jingham added a comment. In D129307#3636695 , @clayborg wrote: > In D129307#3636573 , @jingham wrote: > >> I'm not entirely clear what problem this is solving. Any actor setting >> breakpoints can already choose

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

clayborg added a comment. In D129307#3636573 , @jingham wrote: > I'm not entirely clear what problem this is solving. Any actor setting > breakpoints can already choose the match depth by simply providing that many > directory components. I.e. if I kn

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I'm not entirely clear what problem this is solving. Any actor setting breakpoints can already choose the match depth by simply providing that many directory components. I.e. if

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan updated this revision to Diff 442973. yinghuitan added a comment. Remove unnecessary format changes caused by IDE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129307/new/ https://reviews.llvm.org/D129307 Files: lldb/include/lldb/Bre

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some build system (li