[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc732afa2c2e8: [lldb] [llgs] Fix disabling non-stop mode (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks much better. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128893/new/ https://reviews.llvm.org/D128893 ___ lldb-commits mai

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

mgorny updated this revision to Diff 444727. mgorny added a comment. Use a single `bool` member to indicate whether we're still waiting for any process to stop. Turned out pretty easy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128893/new/ https://reviews.llvm.org/D128893 Files:

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

mgorny added a comment. Hmm, I suppose that makes sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128893/new/ https://reviews.llvm.org/D128893 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

labath added a comment. Actually, on second thought (:D) do we even need a per-process flag for this? Turning off non-stop should stop _all_ processes, so instead of checking whether there are any processes with the 'stopping-due-to-qnonstop` flag around, couldn't we just check if we have any u

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

mgorny updated this revision to Diff 444295. mgorny added a comment. Implemented the requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128893/new/ https://reviews.llvm.org/D128893 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp lldb

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1913-1915 + auto process_it = m_inhibit_stop_reason_processes.find(process.GetID()); + if (process_it != m_inhibit_sto

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

mgorny added a comment. In D128893#3647663 , @labath wrote: > In D128893#3621673 , @mgorny wrote: > >> FYI, I don't feel very strongly about this. If you really dislike adding >> `m_inhibit_stop_reason_processes`

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

labath added a comment. In D128893#3621673 , @mgorny wrote: > FYI, I don't feel very strongly about this. If you really dislike adding > `m_inhibit_stop_reason_processes`, I suppose we could alternatively just > declare disabling non-stop as unsupported

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

mgorny added a comment. FYI, I don't feel very strongly about this. If you really dislike adding `m_inhibit_stop_reason_processes`, I suppose we could alternatively just declare disabling non-stop as unsupported and error out. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128893/new/

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Stop all processes and clear notification queues when disabling non-stop mode. Ensure that no