Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

2015-09-16 Thread Adrian McCarthy via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247829: Add first tests for mini-dump debugging. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D12888?vs=34906&id=34909#toc Repository: rL LLVM http://reviews.llvm.org/D12

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

2015-09-16 Thread Zachary Turner via lldb-commits
looks fine. On Wed, Sep 16, 2015 at 11:02 AM Adrian McCarthy wrote: > amccarth updated this revision to Diff 34906. > amccarth added a comment. > > Addressed earlier comments and moved to functionalities\postmortem\minidump > > > http://reviews.llvm.org/D12888 > > Files: > test/functionalities

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

2015-09-16 Thread Adrian McCarthy via lldb-commits
amccarth updated this revision to Diff 34906. amccarth added a comment. Addressed earlier comments and moved to functionalities\postmortem\minidump http://reviews.llvm.org/D12888 Files: test/functionalities/postmortem/minidump/TestMiniDump.py test/functionalities/postmortem/minidump/fizzbuz

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

2015-09-16 Thread Adrian McCarthy via lldb-commits
amccarth added a comment. In http://reviews.llvm.org/D12888#247212, @zturner wrote: > In http://reviews.llvm.org/D12888#247195, @amccarth wrote: > > > > Instead of test/functionalities/minidump, I would probably call this > > > test/functionalities/core-file/windows. > > > > > > Hmm... > > > > T

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

2015-09-16 Thread Zachary Turner via lldb-commits
zturner added a comment. In http://reviews.llvm.org/D12888#247195, @amccarth wrote: > > Instead of test/functionalities/minidump, I would probably call this > > test/functionalities/core-file/windows. > > > Hmm... > > There is talk of (eventually) debugging minidumps on other platforms. Also >

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

2015-09-16 Thread Adrian McCarthy via lldb-commits
amccarth marked 2 inline comments as done. amccarth added a comment. > Instead of test/functionalities/minidump, I would probably call this > test/functionalities/core-file/windows. Hmm... There is talk of (eventually) debugging minidumps on other platforms. Also some crash capture tools can

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

2015-09-16 Thread Zachary Turner via lldb-commits
zturner added a comment. Instead of test/functionalities/minidump, I would probably call this test/functionalities/core-file/windows. I'm using core-file instead of minidump because it's the most generic term that will make sense on all platforms, and other platforms will essentially want to a

[Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

2015-09-15 Thread Adrian McCarthy via lldb-commits
amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. This includes a dump file captured using Visual Studio, of the enclosed sample program, which was also build with Visual Studio. The tests just verify that LLDB can access some very bas