This revision was automatically updated to reflect the committed changes.
Closed by commit rL254588: [LLDB] Switch to assembly view if source is moved
(authored by mohit.bhakkad).
Changed prior to commit:
http://reviews.llvm.org/D12877?vs=38799&id=41714#toc
Repository:
rL LLVM
http://review
jasonmolenda added a comment.
Yep, Greg said the patch is good to commit.
Repository:
rL LLVM
http://reviews.llvm.org/D12877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mohit.bhakkad added a comment.
@jingham, @jasonmolenda,
is it okay to commit it?
Repository:
rL LLVM
http://reviews.llvm.org/D12877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
mohit.bhakkad updated this revision to Diff 38799.
mohit.bhakkad added a comment.
Changes in this revision:
- changed no-source to no-debuginfo and made it default
- now no-source means display assembly if source file is missing, even if
debug-info is present.
Repository:
rL LLVM
http://rev
mohit.bhakkad added a comment.
Hi Jason, thanks for your suggestions. Yes, this approach looks good and one
time warning should be helpful from users view, I will implement it get back
with a patch soon.
Repository:
rL LLVM
http://reviews.llvm.org/D12877
_
jasonmolenda added a comment.
I chatted with Jim and Greg about this today. We have a
"`stop-disassembly-display`" setting right now. It can be one of three values:
never: never show assembly
no-source: show assembly when we have no debug information
always: always show assembly
"no-source" i
jasonmolenda added a subscriber: jasonmolenda.
jasonmolenda added a comment.
Maybe I'm an outlier here -- but I don't think we should show assembly code,
unless specifically requested by the user, when we can't find a source file
(but we have source-level debug information).
lldb used to behave
clayborg requested changes to this revision.
clayborg added a comment.
Ok, so Jim and I agreed verbally on the solution. If we have source, but we
don't have the source file itself, then we should print the line table entry
out. This can be done with:
if (num_lines == 0)
{
const bool
clayborg added a comment.
Maybe we can enable mixed mode display where it intersperses the source file
and line in the disassembly when/if there is source info, but no source file?
Repository:
rL LLVM
http://reviews.llvm.org/D12877
___
lldb-comm
> On Sep 15, 2015, at 2:27 PM, Greg Clayton wrote:
>
> clayborg accepted this revision.
> clayborg added a comment.
>
> I would rather not see a warning. If you don't have sources I don't really
> want to see:
>
> warning: couldn't find foo.c
> 0x1000: add r1, r2, r3
>
>
>
Why not? T
clayborg accepted this revision.
clayborg added a comment.
I would rather not see a warning. If you don't have sources I don't really want
to see:
warning: couldn't find foo.c
0x1000: add r1, r2, r3
Repository:
rL LLVM
http://reviews.llvm.org/D12877
_
jingham added a subscriber: jingham.
jingham requested changes to this revision.
jingham added a reviewer: jingham.
jingham added a comment.
This revision now requires changes to proceed.
This change means that the two cases "no debug info" and "couldn't find your
sources" end up looking very sim
mohit.bhakkad created this revision.
mohit.bhakkad added a reviewer: clayborg.
mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain,
lldb-commits.
mohit.bhakkad set the repository for this revision to rL LLVM.
Repository:
rL LLVM
http://reviews.llvm.org/D12877
Files:
source
13 matches
Mail list logo
