This revision was automatically updated to reflect the committed changes.
Closed by commit rL247662: Use uint64_t for GoArray size. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D12872?vs=34775&id=34776#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12872
Files:
ribrdb accepted this revision.
ribrdb added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D12872
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
brucem added a comment.
This is meant to fix this warning:
llvm/tools/lldb/source/Symbol/GoASTContext.cpp:1107:40: warning: comparison
of integers of different signs: 'size_t' (aka 'unsigned long') and 'int64_t'
(aka 'long long') [-Wsign-compare]
if (ignore_array_bounds || idx < a->
brucem created this revision.
brucem added reviewers: ribrdb, clayborg.
brucem added a subscriber: lldb-commits.
This was int64_t, but all usages of it came from code that was passing
in unsigned values. The usages of the array size, except for one, were
also treating it as an unsigned value. The
