This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbe265d25ca5e: [lldb] Add support for specifying a log
handler (authored by JDevlieghere).
Herald added a project: LLDB.
Repository:
rG LLVM Github
mib added inline comments.
Comment at: lldb/source/Commands/CommandObjectLog.cpp:167
buffer_size.Clear();
+ handler = eLogHandlerStream;
log_options = 0;
labath wrote:
> mib wrote:
> > clayborg wrote:
> > > Do we want to define a "eLogHandlerDe
JDevlieghere updated this revision to Diff 439874.
JDevlieghere added a comment.
Improve help and error message
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128323/new/
https://reviews.llvm.org/D128323
Files:
lldb/include/lldb/Core/Debugger.h
lldb/include/lldb/lldb-enumerations.h
JDevlieghere updated this revision to Diff 439866.
JDevlieghere added a comment.
Add `eLogHandlerDefault = eLogHandlerStream`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128323/new/
https://reviews.llvm.org/D128323
Files:
lldb/include/lldb/Core/Debugger.h
lldb/include/lldb/lldb-
labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/source/Commands/CommandObjectLog.cpp:167
buffer_size.Clear();
+ handler = eLogHandlerStream;
log_options = 0;
mib wro
JDevlieghere updated this revision to Diff 439575.
JDevlieghere marked 2 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128323/new/
https://reviews.llvm.org/D128323
Files:
lldb/include/lldb/Core/Debugger.h
lldb/include/lldb/lldb-enumerations.h
lldb/include/l
JDevlieghere marked 6 inline comments as done.
JDevlieghere added a subscriber: jingham.
JDevlieghere added inline comments.
Comment at: lldb/source/Commands/CommandObjectLog.cpp:26
+static constexpr OptionEnumValueElement g_log_handler_type[] = {
+{
claybo
clayborg added inline comments.
Comment at: lldb/source/Commands/CommandObjectLog.cpp:26
+static constexpr OptionEnumValueElement g_log_handler_type[] = {
+{
Question: how does one see these values and their descriptions? Do the
descriptions get displayed
JDevlieghere updated this revision to Diff 439170.
JDevlieghere marked 2 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128323/new/
https://reviews.llvm.org/D128323
Files:
lldb/include/lldb/Core/Debugger.h
lldb/include/lldb/lldb-private-enumerations.h
lldb/s
JDevlieghere marked 11 inline comments as done.
JDevlieghere added inline comments.
Comment at: lldb/source/Commands/Options.td:436-437
Desc<"Set the log to be buffered, using the specified buffer size.">;
+ def log_handler : Option<"handler", "h">, Group<1>,
+EnumArg<"
mib added inline comments.
Comment at: lldb/source/Commands/CommandObjectLog.cpp:167
buffer_size.Clear();
+ handler = eLogHandlerStream;
log_options = 0;
clayborg wrote:
> Do we want to define a "eLogHandlerDefault" which points to
> "eLogHand
mib added inline comments.
Comment at: lldb/source/Core/Debugger.cpp:1409-1411
+static std::shared_ptr
+CreateLogHandler(LogHandlerKind log_handler_kind, int fd, bool should_close,
+ size_t buffer_size) {
Many (or most) arguments passed to this fu
clayborg added inline comments.
Comment at: lldb/include/lldb/lldb-private-enumerations.h:229
+ eLogHandlerCallback,
+ eLogHandlerRotating,
+#if defined(__APPLE__)
Maybe "eLogHandlerCircular"?
Comment at: lldb/include/lldb/lldb-private-enumer
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, clayborg, kastiglione, mib.
Herald added a project: All.
JDevlieghere requested review of this revision.
This patch adds a new flag to `log enable` allowing the user to specify a log
handler. This makes it possible to enabl
14 matches
Mail list logo
