[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

stella.stamenova added a comment. Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/20566 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8ad018869ae: [lldb] fix stepping through POSIX trampolines (authored by mdaniels, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

mdaniels added a comment. I do not have commit access, so I would need someone to commit for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

labath accepted this revision. labath added a comment. Cool, thanks. So do you have commit access, or you need someone to commit this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999 ___ lld

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

mdaniels added inline comments. Comment at: lldb/test/API/lang/cpp/step-into-namespace/TestStepIntoNamespace.py:5 + +class StepIntoNamespace(TestBase): +mydir = TestBase.compute_mydir(__file__) labath wrote: > Am I correct in assuming that the "namespace" pa

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

mdaniels updated this revision to Diff 438347. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp lldb/test/API/lang/cpp/step-through-trampoline/Makefile lldb/test

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/lang/cpp/step-into-namespace/TestStepIntoNamespace.py:5 + +class StepIntoNamespace(TestBase): +mydir = TestBase.compute_mydir(__file__) ---

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

mdaniels added a comment. @JDevlieghere could you confirm my understanding of the issue here is correct? It looks like https://github.com/llvm/llvm-project/issues/54250 is the same issue, and should be fix with this as well. Comment at: lldb/test/API/lang/cpp/step-into-names

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

clayborg added a comment. LGTM, just a question if we want to restrict this test to linux only. Comment at: lldb/test/API/lang/cpp/step-into-namespace/TestStepIntoNamespace.py:8 + +def test(self): +self.build() Do we want to limit this to linux? I

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

mdaniels updated this revision to Diff 437741. mdaniels added a comment. Added a simple test case that reproduces the issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOS

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

clayborg added a comment. Is there a test that was failing with this? If not can we add one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999 ___ lldb-commits ma

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

mdaniels created this revision. mdaniels added reviewers: jingham, clayborg, labath. Herald added a project: All. mdaniels requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The DynamicLoaderPOSIXDYLD::GetStepThroughTrampolinePlan() function w