This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
JDevlieghere marked an inline comment as done.
Closed by commit rG6ac608b3d897: [lldb] Add RotatingLogHandler (authored by
JDevlieghere).
Herald added a project: LLDB.
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
Comment at: lldb/unittests/Utility/LogTest.cpp:112
+ handler.Dump(stream);
+ return stream.str();
+}
kastiglione wrote:
> minor: `return buffer;`
I did that on purpose to avoid t
kastiglione accepted this revision.
kastiglione added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lldb/unittests/Utility/LogTest.cpp:112
+ handler.Dump(stream);
+ return stream.str();
+}
minor: `return buffer;`
CHANGES SINCE
JDevlieghere updated this revision to Diff 437695.
JDevlieghere added a comment.
- Use dynamic array instead of vector.
- Rebase
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127937/new/
https://reviews.llvm.org/D127937
Files:
lldb/include/lldb/Utility/Log.h
lldb/source/Utility/Log
kastiglione added inline comments.
Comment at: lldb/include/lldb/Utility/Log.h:98
+
+ std::vector m_messages;
+ size_t m_next_index = 0;
this could be an array, since it's not being dynamically resized.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D12
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, kastiglione, mib.
Herald added a project: All.
JDevlieghere requested review of this revision.
Add a log handler that maintains a circular buffer.
https://reviews.llvm.org/D127937
Files:
lldb/include/lldb/Utility/Log.h
