[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

cmtice added a comment. I apologize; I was looking at several commits, and I accidentally added my comment to the wrong one. No, this commit is not the one that caused my problem (I am very sorry about the confusion). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added a comment. @cmtice, are you sure the failure is caused by/related with this patch? This is a pure lldb-vscode change which is not used by normal lldb. Also, no mention of code in this patch in the error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

cmtice added a comment. Just FYI, this commit appears to cause lldb//test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py to fail. The error I'm seeing is: Traceback (most recent call last): File "../lldb/test/API/commands/target/auto-install-main-executab

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added a comment. Fixed in https://reviews.llvm.org/D128234 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added a comment. Sorry, I was fooled by the buildbot which says everything is green. Working on a fix for the build break now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702 _

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

thakis added a comment. Here too: https://lab.llvm.org/buildbot#builders/83/builds/20210 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

thakis added a comment. Looks like this might not build: http://45.33.8.238/linux/79194/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c6e138aa893: Support logpoints in lldb-vscode (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan updated this revision to Diff 438448. yinghuitan added a comment. Using a single structured LogMessagePart per suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702 Files: lldb/packages

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

clayborg added a comment. I would like to get to one array solution of LogMessagePart entries and avoid having two arrays of strings that need to stay in sync (rawTextMessages and evalExpressions). Simpler to understand and no need to document the interdependence of rawTextMessages and evalExpr

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added inline comments. Herald added a subscriber: Michael137. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_logpoints.py:60 +[loop_line, after_loop_line], +[{'logMessage': logMessage}, {}] +) claybor

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/BreakpointBase.cpp:126 +const llvm::StringRef &expr = bp->evalExpressions[i]; +// TODO: try local variables first. +lldb::SBValue value = frame.EvaluateExpression(expr.str().c_str());

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_logpoints.py:60 +[loop_line, after_loop_line], +[{'logMessage': l

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch implements