brucem added a comment.
The error is not setting m_bInitialized in the Initialize method on the
LogMediumFile class.
Will fix when back at computer.
Repository:
rL LLVM
http://reviews.llvm.org/D12764
___
lldb-commits mailing list
lldb-commits@l
brucem added a comment.
This seems to have broken 2 tests. I have to step out for about 3 hours, but
will fix it when I return.
Repository:
rL LLVM
http://reviews.llvm.org/D12764
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247388: [lldb-mi] Remove MIUtilSystem*. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D12764?vs=34514&id=34531#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12764
Files:
ki.stfu accepted this revision.
ki.stfu added a comment.
lgtm
http://reviews.llvm.org/D12764
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brucem updated this revision to Diff 34514.
brucem added a comment.
Removing an error check that is no longer needed and the corresponding
error message.
A broader cleanup is possible here, but I would rather do that as a
separate commit.
http://reviews.llvm.org/D12764
Files:
lldb.xcodeproj/
abidh requested changes to this revision.
abidh added a comment.
This revision now requires changes to proceed.
There is a check on m_strMediumFileDirectory in
CMICmnLogMediumFile::FileFormFileNamePath which may needs to be updated.
Otherwise looks ok to me.
http://reviews.llvm.org/D12764
_
brucem created this revision.
brucem added reviewers: ki.stfu, domipheus, abidh.
brucem added a subscriber: lldb-commits.
This platform-specific code wasn't fully implemented and wasn't
actually needed. There was one call for the log file path and
that has been addressed.
http://reviews.llvm.org/
