tberghammer added a comment.
I see. Thank you for the clarification
Repository:
rL LLVM
http://reviews.llvm.org/D12757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham added a subscriber: jingham.
jingham added a comment.
The point of the file name check is to catch the case where you had nested
inlines that share the same address, and the compiler (errantly, but...)
decided to emit duplicate entries at the same address for the two levels of
inlining.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247788: Fix prologue end handling when code compiled by gcc
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12757?vs=34435&id=34886#toc
Repository:
rL LLVM
http://review
tberghammer added a comment.
The line number is not always the same for the 2 entry (the first one points to
the open '{' and the second one to the first instruction of the function). I
added the check for the file name, but I would be quite surprised if we find a
scenario when the file names d
clayborg added a comment.
Blech... Ok, one more try: does GCC always emit the same line and file with the
same address? If so we could do:
{
// GCC don't use the is_prologue_end flag to mark the first instruction
after the prologue.
// Instead of it it is issueing a line table ent
tberghammer added a comment.
In http://reviews.llvm.org/D12757#246497, @clayborg wrote:
> Maybe we can try still removing duplicates, but remembering the first index
> where we had a duplicate line entry. If we don't get a prologue end, then we
> got back to the index we remembered for the firs
clayborg added a comment.
Maybe we can try still removing duplicates, but remembering the first index
where we had a duplicate line entry. If we don't get a prologue end, then we
got back to the index we remembered for the first duplicate and if it is valid,
modify that entry to say "prologue_e
tberghammer added a comment.
Hi Greg, what do you think about my inline suggestion? Are you fine with
removing the original hack about removing duplicate entries from the line table
end then solve the problem around duplicate line entries with always returning
the last entry if we have multiple
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
see inlined comments.
Comment at: source/Symbol/LineTable.cpp:107-117
@@ -106,3 +106,13 @@
if (!entries.empty() && entries.back().file_addr == file_addr)
+
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Fix prologue end handling when code compiled by gcc
GCC don't use the is_prologue_end flag to mark the first instruction
after the prologue. Instead of it it is issuing a line
10 matches
Mail list logo
