Re: [Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

2015-10-01 Thread Bruce Mitchener via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248990: Include platform agnostic in the place of (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D12748?vs=35950&id=36194#toc Repository: rL LLVM http://reviews.llvm.org/D1

Re: [Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

2015-09-29 Thread Kamil Rytarowski via lldb-commits
krytarowski updated this revision to Diff 35950. krytarowski added a comment. Use proper include. Repository: rL LLVM http://reviews.llvm.org/D12748 Files: tools/lldb-server/lldb-gdbserver.cpp Index: tools/lldb-server/lldb-gdbserver.cpp

Re: [Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

2015-09-29 Thread Bruce Mitchener via lldb-commits
brucem requested changes to this revision. brucem added a reviewer: brucem. This revision now requires changes to proceed. Comment at: tools/lldb-server/lldb-gdbserver.cpp:30 @@ -30,2 +29,3 @@ #include "lldb/Core/PluginManager.h" +#include "lldb/Host/common/GetOptInc.h" #include

Re: [Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

2015-09-28 Thread Kamil Rytarowski via lldb-commits
krytarowski updated this revision to Diff 35923. krytarowski added a comment. Put the include into proper line and use "" instead of <>. Repository: rL LLVM http://reviews.llvm.org/D12748 Files: tools/lldb-server/lldb-gdbserver.cpp Index: tools/lldb-server/lldb-gdbserver.cpp =

Re: [Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

2015-09-27 Thread Bruce Mitchener via lldb-commits
brucem added a subscriber: brucem. Comment at: tools/lldb-server/lldb-gdbserver.cpp:10 @@ -9,1 +9,3 @@ +#include + I suspect that this should `#include "lldb/Host/HostGetOpt.h"` instead, and that it should be down below with the other Host includes. Reposito

Re: [Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

2015-09-18 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Any interest? Repository: rL LLVM http://reviews.llvm.org/D12748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

2015-09-09 Thread Kamil Rytarowski via lldb-commits
krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Problem caught on NetBSD with missing getopt_long_only(3). Repository: rL LLVM http://reviews.llvm.org/D12748 File