This revision was automatically updated to reflect the committed changes.
Closed by commit rL247568: The pipe2(2) call is supported on NetBSD (authored
by emaste).
Changed prior to commit:
http://reviews.llvm.org/D12746?vs=34512&id=34674#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1274
krytarowski added a comment.
Please commit it if it's OK.
Repository:
rL LLVM
http://reviews.llvm.org/D12746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski updated this revision to Diff 34512.
krytarowski added a comment.
rediff the comment
Repository:
rL LLVM
http://reviews.llvm.org/D12746
Files:
source/Host/posix/PipePosix.cpp
Index: source/Host/posix/PipePosix.cpp
===
krytarowski added inline comments.
Comment at: source/Host/posix/PipePosix.cpp:39
@@ -38,3 +38,3 @@
-// pipe2 is supported by Linux, FreeBSD v10 and higher.
+// pipe2 is supported by Linux, FreeBSD v10 and higher, NetBSD 6.0 and newer
// TODO: Add more platforms that support pi
emaste added a subscriber: emaste.
Comment at: source/Host/posix/PipePosix.cpp:39
@@ -38,3 +38,3 @@
-// pipe2 is supported by Linux, FreeBSD v10 and higher.
+// pipe2 is supported by Linux, FreeBSD v10 and higher, NetBSD 6.0 and newer
// TODO: Add more platforms that support pi
I think the main reason behind it is that we have about three build
systems. Any check you write will need to be implemented in all of
them. Maybe when autoconf goes away, we can do a build check in cmake
and xcode can just hardcode -DPIPE2_SUPPORTED=0, since it is only used
on darwin anyway.
On 1
On Thu, Sep 10, 2015 at 01:15:43AM +, Kamil Rytarowski wrote:
> Linux and NetBSD versions are compatible, modulo flag values:
> - O_CLOEXEC and O_NONBLOCK are the same,
> - O_NOSIGPIPE on NetBSD,
> - O_DIRECT on Linux.
I wonder why we don't just detect this via appropiate build test.
There sho
krytarowski created this revision.
krytarowski added a reviewer: joerg.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
Linux and NetBSD versions are compatible, modulo flag values:
- O_CLOEXEC and O_NONBLOCK are the same,
- O_NOSIGPIPE on
