ovyalov added a comment.
In http://reviews.llvm.org/D12677#242290, @abhishek.aggarwal wrote:
> In http://reviews.llvm.org/D12677#242006, @ovyalov wrote:
>
> > I reverted the CL because it was causing
> > TestRegisters.test_fp_special_purpose_register_read to fail on OSX:
> >
> > - stop reason =
abhishek.aggarwal added a comment.
In http://reviews.llvm.org/D12677#242006, @ovyalov wrote:
> I reverted the CL because it was causing
> TestRegisters.test_fp_special_purpose_register_read to fail on OSX:
>
> - stop reason = EXC_BREAKPOINT
> - "register read ftag" yields 0x80 instead of expecte
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
I reverted the CL because it was causing
TestRegisters.test_fp_special_purpose_register_read to fail on OSX:
- stop reason = EXC_BREAKPOINT
- "register read ftag" yields 0x80 instead of expected 0x8000
http://reviews.llvm.org/D126
abhishek.aggarwal closed this revision.
abhishek.aggarwal added a comment.
Couldn't land this patch by arc due to merge conflicts. Hence merging it
manually and closing this revision.
http://reviews.llvm.org/D12677
___
lldb-commits mailing list
lld
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks good. please also close the relevant bug after submission.
http://reviews.llvm.org/D12677
___
lldb-commits mailing list
lldb-commits@lists.
abhishek.aggarwal updated this revision to Diff 34161.
abhishek.aggarwal added a comment.
Clang/GCC generate different assembly for same inferior.
Changed a.cpp to remove dependency of TestRegisters.py on assembly
instructions generated by Clang/GCC.
Changed TestRegisters.py to write a generic t
abhishek.aggarwal added inline comments.
Comment at: test/functionalities/register/TestRegisters.py:195
@@ +194,3 @@
+for x in range(0,16):
+self.runCmd ("si", RUN_SUCCEEDED)
+
labath wrote:
> First I would like to applaud for writing a
labath added a subscriber: lldb-commits.
Comment at: test/functionalities/register/TestRegisters.py:195
@@ +194,3 @@
+for x in range(0,16):
+self.runCmd ("si", RUN_SUCCEEDED)
+
First I would like to applaud for writing a test case for s