zturner closed this revision.
zturner added a comment.
Sorry this took so long, I forgot about it. It has been committed in r247842.
http://reviews.llvm.org/D12672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
jeremi.piotrowski added a comment.
I do not have commit access, so if you could do it for me that would be great.
http://reviews.llvm.org/D12672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Looks fine, do you have commit access? If so feel free to commit
whenever. Otherwise I can do it for you tomorrow
On Mon, Sep 7, 2015 at 1:15 PM Jeremi Piotrowski <
jeremi.piotrow...@gmail.com> wrote:
> jeremi.piotrowski updated this revision to Diff 34169.
> jeremi.piotrowski added a comment.
zturner added a comment.
Looks fine, do you have commit access? If so feel free to commit
whenever. Otherwise I can do it for you tomorrow
http://reviews.llvm.org/D12672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.o
jeremi.piotrowski updated this revision to Diff 34169.
jeremi.piotrowski added a comment.
- combine nested if conditions with `and` as suggested by zturner
and remove condtition from `endif` as that seems to be the convention.
http://reviews.llvm.org/D12672
Files:
cmake/LLDBDependencies.cm
zturner added a subscriber: zturner.
zturner added a comment.
Looks fine to me, but as a nitpick, I would suggest combining the nested if
into a single if with an AND clause.
http://reviews.llvm.org/D12672
___
lldb-commits mailing list
lldb-commits@
jeremi.piotrowski created this revision.
jeremi.piotrowski added a subscriber: lldb-commits.
Ncurses related symbols can either all be found in libnurses or split between
libncurses and libtinfo. The main LLVM cmake scripts look for the setupterm
symbol and stores the library that has it in TERMIN
