Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

2015-09-14 Thread Stephane Sezer via lldb-commits
sas closed this revision. sas added a comment. Committed as r247579. Repository: rL LLVM http://reviews.llvm.org/D12659 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

2015-09-14 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Please commit it if it's OK. Repository: rL LLVM http://reviews.llvm.org/D12659 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

2015-09-10 Thread Kamil Rytarowski via lldb-commits
krytarowski updated this revision to Diff 34510. krytarowski added a comment. Rework the comment regarding SI_KERNEL. Repository: rL LLVM http://reviews.llvm.org/D12659 Files: source/Plugins/Process/POSIX/CrashReason.cpp Index: source/Plugins/Process/POSIX/CrashReason.cpp

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

2015-09-10 Thread Ed Maste via lldb-commits
emaste added a comment. In http://reviews.llvm.org/D12659#243729, @krytarowski wrote: > In http://reviews.llvm.org/D12659#243415, @sas wrote: > > > > > > To something more generic: > > // Some platforms will occasionally send nonstandard spurious SI_KERNEL > codes. > // One way to get this i

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

2015-09-10 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D12659#243415, @sas wrote: > Makes sense. Adding a tiny comment explaining which platforms get SI_KERNEL > might be a good idea here. Can I replace the following comment: // Linux will occasionally send spurious SI_KERNEL codes. // (

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

2015-09-10 Thread Stephane Sezer via lldb-commits
sas added a subscriber: sas. sas accepted this revision. sas added a reviewer: sas. sas added a comment. This revision is now accepted and ready to land. Makes sense. Adding a tiny comment explaining which platforms get SI_KERNEL might be a good idea here. Repository: rL LLVM http://reviews.

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

2015-09-09 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Still valid. Repository: rL LLVM http://reviews.llvm.org/D12659 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

2015-09-04 Thread Kamil Rytarowski via lldb-commits
krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Herald added a subscriber: emaste. Linux and FreeBSD occasionally send SI_KERNEL codes, nonexistent on other platforms